feat: Add LiveQuery module to SDK #1712

vazarkevych · 2023-02-24T11:57:35Z

New Pull Request Checklist

Issue

Closes: #1714

TODOs before merging

Added module ParseLiveQuery to SDK project
Added SPM support for the module ParseLiveQuery
Added build module ParseLiveQuery from CI/CD (this change needs to check because the test finished with an error. Locally everything works but on the repo we have an error)

parse-github-assistant · 2023-02-24T11:57:38Z

Thanks for opening this pull request!

🎉 We are excited about your hands-on contribution!

mtrezza · 2023-03-10T16:22:49Z

@vazarkevych Could you give a description of the issues that are stopping this PR currently?

And could you please do a rebase to resolve the conflicts? Maybe the latest workflow changes address some of the issues. If you have any questions regarding the new workflow, maybe @dplewis could give a hand...

dplewis · 2023-03-10T17:13:09Z

@vazarkevych I can give a hand, can you give me access to your fork?

vazarkevych · 2023-03-13T15:14:01Z

@dplewis I gave access you to my fork

vazarkevych · 2023-03-29T10:39:12Z

Hi, @dplewis, Just a kind follow-up regarding the status of the ParseLiveQuery. Do you have any updates on your side?

dplewis · 2023-03-30T16:39:52Z

@vazarkevych I fixed the merge conflict waiting for CI to pass

codecov · 2023-03-30T17:08:48Z

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (cbab34c) 78.17% compared to head (413aec7) 78.16%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   78.17%   78.16%   -0.01%     
==========================================
  Files         307      307              
  Lines       36803    36803              
==========================================
- Hits        28770    28768       -2     
- Misses       8033     8035       +2

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

dplewis · 2023-03-30T22:03:35Z

@vazarkevych I got the live query project to build successfully, looks like the release build is broken

dplewis · 2023-03-31T16:20:07Z

@vazarkevych I got the release working but ParseLiveQuery-OSX is broken. I don't know why BoltsSwift is compiling to macOS 10.10 in the CI and locally for me.

❌  /Users/runner/work/Parse-SDK-iOS-OSX/Parse-SDK-iOS-OSX/ParseLiveQuery/ParseLiveQuery/Internal/ClientPrivate.swift:13:8: compiling for macOS 10.10, but module 'BoltsSwift' has a minimum deployment target of macOS 10.15: /Users/runner/work/Parse-SDK-iOS-OSX/Parse-SDK-iOS-OSX/build/macOS/Release-osx-macosx/BoltsSwift.framework/Modules/BoltsSwift.swiftmodule/x86_64-apple-macos.swiftmodule

dplewis · 2023-03-31T21:25:03Z

@vazarkevych @mtrezza The project builds , the examples compile and run, and the CI is working. I'm not familiar with how SPM works, can you check it?

mtrezza · 2023-04-02T14:45:41Z

@vazarkevych Could you look into the remaining issues so we can get this merged?

vazarkevych · 2023-04-05T10:42:12Z

Hi @dplewis, thank you for your contribution. I just checked SPM, and it stopped working

dplewis · 2023-04-05T16:15:12Z

@vazarkevych I don't think I changed anything SPM related.

dplewis · 2023-04-12T22:06:24Z

@vazarkevych @mtrezza I got this to work via SPM. I added ParseObjC and ParseLiveQuery to my project from your github url and addParseLiveQuery branch. Then used

#import "Parse.h"
@import ParseLiveQuery;

I just checked SPM, and it stopped working

What stopped working?

dplewis

Documentation, README, code coverage, starter projects, demo, and tests can be done in separate PRs. Also there are still PR's left on the LiveQuery repo that need to be addressed

mtrezza · 2023-04-13T16:09:18Z

Amazing! Maybe we could at least copy/paste the LiveQuery README to this README under a new chapter? Or is that content now outdated because of the migration?

dplewis · 2023-04-13T16:48:31Z

That documentation is outdated and very hard to get working for new users, I can't get it working. Once the project is migrated the LiveQuery code needs some TLC

mtrezza · 2023-04-13T18:31:35Z

Got it, then let's just wait for a review by @vazarkevych to confirm all is working as expected and then merge.

mtrezza · 2023-04-13T18:33:50Z

Anyone could try this out and confirm the LiveQuery module is working?

@parse-community/ios-sdk @extnous @HackShitUp

mtrezza · 2023-04-14T09:01:30Z

Package.swift

@@ -10,19 +10,22 @@ let package = Package(
                .tvOS(.v12),
                .watchOS(.v2)],
    products: [
-        .library(name: "ParseObjC", targets: ["ParseCore"]),
+        .library(name: "ParseObjC", targets: ["Parse"]),


Why this change and is this a breaking change?

It seems a bit odd to name the core module Parse, as the term "Parse" is arguably referring to the whole SDK. To me is makes more sense to name the core module ParseCore to indicate that it's the basis that is always needed, while others are optional.

Hi, yes it is an important change because in SDK target has the name "Parse". When we set "ParseCore" it causes an error downloading.

Not sure I understand. Why can't we keep the name ParseCore? I mean this is only an issue for the LiveQuery module, right? Otherwise we make a breaking change because developers changed their imports from Parse to ParseCore with the introduction of SPM, and now we are changing it back to Parse.

@mtrezza This is my first time using SPM and I didn't know you had to do import ParseCore;. I can try to revert it back and fix the downloading error. @vazarkevych Thoughts?

@vazarkevych Could you take a look at this so we can close this PR? It seems to be the last remaining issue here.

@mtrezza Can you commit 1 example of tedious work? I'll finish the rest. I don't quite understand what needs to be changed

See #1712 (comment). The module name ParseCore shouldn't change, just because we're adding the LiveQuery module in this PR. Otherwise this PR becomes a breaking change, but it's just a feature addition.

So I'd simply remove the renaming and then go into the LiveQuery module and make sure it uses the ParseCore reference. It seems the issue is that the LiveQuery module is looking for the Parse module by using its old Parse reference instead of the ParseCore reference in this repository. To me this looks like a simple find/replace task and some manual correction.

@dplewis Do you want to take a look at this, we could add an additional bounty.

Cartfile.resolved

dplewis · 2023-06-07T08:20:51Z

@mtrezza @vazarkevych @VolodyaNazarkevych This is ready for review.

TODO: #1712 (review)

mtrezza · 2023-06-07T10:46:32Z

Amazing! @VolodyaNazarkevych Could you please take a look at this and test this module out in a project?

# [2.3.0](2.2.0...2.3.0) (2023-06-08) ### Features * Add LiveQuery module to SDK; this deprecates the separate [Parse LiveQuery SDK](https://github.com/parse-community/ParseLiveQuery-iOS-OSX) ([#1712](#1712)) ([154da34](154da34))

parseplatformorg · 2023-06-08T17:43:34Z

🎉 This change has been released in version 2.3.0

feat: Add module LiveQuery to Parse SDK project

132a8d1

mtrezza changed the title ~~WIP: feat: Add module LiveQuery to Parse SDK project~~ feat: Add module LiveQuery to Parse SDK project Feb 24, 2023

mtrezza marked this pull request as draft February 25, 2023 17:44

vazarkevych added 2 commits February 27, 2023 14:27

update package.swift file for setup SPM

b3c945c

added build ParseLiveQuvery module for each platform from CI/CD

4728be4

vazarkevych force-pushed the addParseLiveQuery branch from 1d61c91 to 4728be4 Compare March 2, 2023 09:07

vazarkevych and others added 2 commits March 2, 2023 11:51

added downloading carthage

f7405fc

Merge branch 'master' into addParseLiveQuery

a33ca50

Merge branch 'master' into addParseLiveQuery

7656ec8

remove missing configurations links

24bfff1

dplewis added 2 commits March 31, 2023 10:11

fix info.plist path

ab190eb

Add live query to release build

4f80d5c

dplewis added 3 commits March 31, 2023 11:58

temporarily remove mac os build

07836f0

Add example projects

de5b6c7

set minimum ios version to 10.15 for bolts swift

56f90c8

dplewis requested a review from a team March 31, 2023 21:29

Clean up cocoapod references

5a4b32f

added path to the info.plist

2eea533

vazarkevych force-pushed the addParseLiveQuery branch from 09214d8 to 2eea533 Compare April 7, 2023 13:21

dplewis previously approved these changes Apr 13, 2023

View reviewed changes

mtrezza marked this pull request as ready for review April 14, 2023 09:00

mtrezza reviewed Apr 14, 2023

View reviewed changes

mtrezza mentioned this pull request Apr 22, 2023

'Parse/Parse.h' file not found when including Parse using SPM #1729

Closed

mtrezza mentioned this pull request May 9, 2023

Merge as module with main SDK parse-community/ParseLiveQuery-iOS-OSX#262

Closed

3 tasks

Point Parse to ParseCore

1f02173

dplewis dismissed their stale review via 1f02173 June 5, 2023 19:18

dplewis added 2 commits June 7, 2023 00:43

ParseLiveQuery standalone project workaround

abd8feb

Add common.swift to mac os target

413aec7

dplewis requested review from proj-sashido, VolodyaNazarkevych, davimacedo and parseplatformorg and removed request for VolodyaNazarkevych and proj-sashido June 7, 2023 16:52

mtrezza changed the title ~~feat: Add module LiveQuery to Parse SDK project~~ feat: Add LiveQuery module to Parse SDK Jun 8, 2023

mtrezza changed the title ~~feat: Add LiveQuery module to Parse SDK~~ feat: Add LiveQuery module to SDK Jun 8, 2023

mtrezza merged commit 154da34 into parse-community:master Jun 8, 2023

parseplatformorg added the state:released Released as stable version label Jun 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add LiveQuery module to SDK #1712

feat: Add LiveQuery module to SDK #1712

vazarkevych commented Feb 24, 2023 •

edited

Loading

parse-github-assistant bot commented Feb 24, 2023 •

edited

Loading

mtrezza commented Mar 10, 2023 •

edited

Loading

dplewis commented Mar 10, 2023

vazarkevych commented Mar 13, 2023

vazarkevych commented Mar 29, 2023

dplewis commented Mar 30, 2023

codecov bot commented Mar 30, 2023 •

edited

Loading

dplewis commented Mar 30, 2023

dplewis commented Mar 31, 2023 •

edited

Loading

dplewis commented Mar 31, 2023 •

edited

Loading

mtrezza commented Apr 2, 2023

vazarkevych commented Apr 5, 2023

dplewis commented Apr 5, 2023

dplewis commented Apr 12, 2023 •

edited

Loading

dplewis left a comment •

edited

Loading

mtrezza commented Apr 13, 2023 •

edited

Loading

dplewis commented Apr 13, 2023 •

edited

Loading

mtrezza commented Apr 13, 2023

mtrezza commented Apr 13, 2023

mtrezza Apr 14, 2023

vazarkevych Apr 24, 2023

mtrezza Apr 24, 2023 •

edited

Loading

dplewis May 9, 2023 •

edited

Loading

mtrezza May 11, 2023

dplewis May 27, 2023

mtrezza May 27, 2023 •

edited

Loading

This comment was marked as off-topic.

This comment was marked as off-topic.

mtrezza Jun 1, 2023

dplewis commented Jun 7, 2023

mtrezza commented Jun 7, 2023 •

edited

Loading

parseplatformorg commented Jun 8, 2023

feat: Add LiveQuery module to SDK #1712

feat: Add LiveQuery module to SDK #1712

Conversation

vazarkevych commented Feb 24, 2023 • edited Loading

New Pull Request Checklist

Issue

TODOs before merging

parse-github-assistant bot commented Feb 24, 2023 • edited Loading

Thanks for opening this pull request!

mtrezza commented Mar 10, 2023 • edited Loading

dplewis commented Mar 10, 2023

vazarkevych commented Mar 13, 2023

vazarkevych commented Mar 29, 2023

dplewis commented Mar 30, 2023

codecov bot commented Mar 30, 2023 • edited Loading

Codecov Report

dplewis commented Mar 30, 2023

dplewis commented Mar 31, 2023 • edited Loading

dplewis commented Mar 31, 2023 • edited Loading

mtrezza commented Apr 2, 2023

vazarkevych commented Apr 5, 2023

dplewis commented Apr 5, 2023

dplewis commented Apr 12, 2023 • edited Loading

dplewis left a comment • edited Loading

Choose a reason for hiding this comment

mtrezza commented Apr 13, 2023 • edited Loading

dplewis commented Apr 13, 2023 • edited Loading

mtrezza commented Apr 13, 2023

mtrezza commented Apr 13, 2023

mtrezza Apr 14, 2023

Choose a reason for hiding this comment

vazarkevych Apr 24, 2023

Choose a reason for hiding this comment

mtrezza Apr 24, 2023 • edited Loading

Choose a reason for hiding this comment

dplewis May 9, 2023 • edited Loading

Choose a reason for hiding this comment

mtrezza May 11, 2023

Choose a reason for hiding this comment

dplewis May 27, 2023

Choose a reason for hiding this comment

mtrezza May 27, 2023 • edited Loading

Choose a reason for hiding this comment

This comment was marked as off-topic.

This comment was marked as off-topic.

mtrezza Jun 1, 2023

Choose a reason for hiding this comment

dplewis commented Jun 7, 2023

mtrezza commented Jun 7, 2023 • edited Loading

parseplatformorg commented Jun 8, 2023

vazarkevych commented Feb 24, 2023 •

edited

Loading

parse-github-assistant bot commented Feb 24, 2023 •

edited

Loading

mtrezza commented Mar 10, 2023 •

edited

Loading

codecov bot commented Mar 30, 2023 •

edited

Loading

dplewis commented Mar 31, 2023 •

edited

Loading

dplewis commented Mar 31, 2023 •

edited

Loading

dplewis commented Apr 12, 2023 •

edited

Loading

dplewis left a comment •

edited

Loading

mtrezza commented Apr 13, 2023 •

edited

Loading

dplewis commented Apr 13, 2023 •

edited

Loading

mtrezza Apr 24, 2023 •

edited

Loading

dplewis May 9, 2023 •

edited

Loading

mtrezza May 27, 2023 •

edited

Loading

mtrezza commented Jun 7, 2023 •

edited

Loading